|
|
Line 1: |
Line 1: |
| When scripting you will often come across problems that are not immediately apparent. This page tries to point out some basic strategies to locate the error.
| | Extrem liże hazowi dupsko a Barcioo liże cipsko Trinowi |
| | | Extrem liże hazowi dupsko a Barcioo liże cipsko Trinowi |
| ==Debug console==
| | Extrem liże hazowi dupsko a Barcioo liże cipsko Trinowi |
| MTA features a built-in debug console that shows debug messages output from MTA functions or from scripts. Keeping it mind that you should have administrator access (unless you modify the ACL to change this), you can open the debug console by typing ''debugscript *x*'' in the console, where ''x'' is the debug level:
| | Extrem liże hazowi dupsko a Barcioo liże cipsko Trinowi |
| * '''1:''' only errors
| | Extrem liże hazowi dupsko a Barcioo liże cipsko Trinowi |
| * '''2:''' errors and warnings
| | Extrem liże hazowi dupsko a Barcioo liże cipsko Trinowi |
| * '''3:''' errors, warnings and info messages
| | Extrem liże hazowi dupsko a Barcioo liże cipsko Trinowi |
| By typing ''debugscript 3'' all messages are visible. Level 3 and level 2 are recommended for most occasions. You should have ''debugscript'' enabled whenever you are testing your scripts as it will help you easily detect and solve typos and other issues.
| | Extrem liże hazowi dupsko a Barcioo liże cipsko Trinowi |
| | | Extrem liże hazowi dupsko a Barcioo liże cipsko Trinowi |
| ===Example===
| | Extrem liże hazowi dupsko a Barcioo liże cipsko Trinowi |
| This example code has two errors:
| | Extrem liże hazowi dupsko a Barcioo liże cipsko Trinowi |
| <syntaxhighlight lang="lua">
| | Extrem liże hazowi dupsko a Barcioo liże cipsko Trinowi |
| function SayHello(message, player)
| | Extrem liże hazowi dupsko a Barcioo liże cipsko Trinowi |
| if (getPlayerName(player) == "Fedor")
| | Extrem liże hazowi dupsko a Barcioo liże cipsko Trinowi |
| outputChatbox("Hello Fedor")
| | Extrem liże hazowi dupsko a Barcioo liże cipsko Trinowi |
| end
| | Extrem liże hazowi dupsko a Barcioo liże cipsko Trinowi |
| end
| | Extrem liże hazowi dupsko a Barcioo liże cipsko Trinowi |
| addEventHandler("onChatMessage", root, SayHello)
| | Extrem liże hazowi dupsko a Barcioo liże cipsko Trinowi |
| </syntaxhighlight>
| | Extrem liże hazowi dupsko a Barcioo liże cipsko Trinowi |
| When the script this piece of code is in is tried to be loaded, debugscript will output something similiar to this:
| | Extrem liże hazowi dupsko a Barcioo liże cipsko Trinowi |
| :{{Debug info|Loading script failed: myResource\script.lua:2: 'then' expected near ´outputChatbox'}}
| | Extrem liże hazowi dupsko a Barcioo liże cipsko Trinowi |
| This means the script could not be parsed because there was a syntax error. It shows the script path relative to the resource directory so you can identify to script where the error originated from. After the filename it shows a colon and a number, this number presents the line number - this is so you can find out where in your script the error is - it is very helpful for large scripts. After that is the error message, which varies depending on the error made. Looking at the error message, we can easily determine that the error originated from the resource '''myResource''' and line two of the script file '''script.lua'''. The error message is very clear, we forgot the "then"! We can easily fix that!
| | Extrem liże hazowi dupsko a Barcioo liże cipsko Trinowi |
| <syntaxhighlight lang="lua">
| | Extrem liże hazowi dupsko a Barcioo liże cipsko Trinowi |
| function SayHello(message, player)
| | Extrem liże hazowi dupsko a Barcioo liże cipsko Trinowi |
| if (getPlayerName(player) == "Fedor") then
| | Extrem liże hazowi dupsko a Barcioo liże cipsko Trinowi |
| outputChatbox("Hello Fedor")
| | Extrem liże hazowi dupsko a Barcioo liże cipsko Trinowi |
| end
| | Extrem liże hazowi dupsko a Barcioo liże cipsko Trinowi |
| end
| | Extrem liże hazowi dupsko a Barcioo liże cipsko Trinowi |
| addEventHandler("onChatMessage", root, SayHello)
| | Extrem liże hazowi dupsko a Barcioo liże cipsko Trinowi |
| </syntaxhighlight>
| | Extrem liże hazowi dupsko a Barcioo liże cipsko Trinowi |
| Now the script will load fine and won't output any errors until a player with the name 'Fedor' says something in the chat. At that moment, the debug console will output:
| | Extrem liże hazowi dupsko a Barcioo liże cipsko Trinowi |
| :{{Debug error|myResource\script.lua:2: attempt to call global 'outputChatbox' (a nil value)}}
| | Extrem liże hazowi dupsko a Barcioo liże cipsko Trinowi |
| This error means that the function '''outputChatbox''' is a nil value, that is - it doesn't exist! This is because the function is actually called [[outputChatBox]], not [[outputChatbox]] - take care of that capital B.:
| | Extrem liże hazowi dupsko a Barcioo liże cipsko Trinowi |
| <syntaxhighlight lang="lua">
| | Extrem liże hazowi dupsko a Barcioo liże cipsko Trinowi |
| function SayHello(message, player)
| | Extrem liże hazowi dupsko a Barcioo liże cipsko Trinowi |
| if (getPlayerName(player) == "Fedor") then
| | Extrem liże hazowi dupsko a Barcioo liże cipsko Trinowi |
| outputChatBox("Hello Fedor")
| | Extrem liże hazowi dupsko a Barcioo liże cipsko Trinowi |
| end
| | Extrem liże hazowi dupsko a Barcioo liże cipsko Trinowi |
| end
| | Extrem liże hazowi dupsko a Barcioo liże cipsko Trinowi |
| addEventHandler("onChatMessage", root, SayHello)
| |
| </syntaxhighlight>
| |
| | |
| Of course, this is just an example and I've only skimmed the surface of error messages. There are plenty of other messages and scenarios, but you should get the general idea.
| |
| | |
| ==Server & client debug logging==
| |
| ====Server====
| |
| Navigate to: ''(MTA root folder)>server>mods>deathmatch''
| |
| | |
| There are two nearly identical files:
| |
| | |
| *The local.conf is the settings for the "host game" menu item in the main menu of MTA. This is a quick and easy way of starting a temporary server from inside the client. When the client is turned off the server will also turn off.
| |
| | |
| *The mtaserver.conf is used when "MTA Server.exe" is executed from (MTA root folder)>server. This runs the server in its own console window which does not need the client to exist or to be run. This is can be useful if you're interested in hosting servers for a longer time period or if you want to experiment with a real world console.
| |
| | |
| Depending on which way you host, you will want to edit those files. The settings in question are:
| |
| | |
| <syntaxhighlight lang="xml"><!-- Specifies the location and name of the debugscript log file. If left blank, server won't be saving this file. -->
| |
| <scriptdebuglogfile>logs/scripts.log</scriptdebuglogfile>
| |
|
| |
| <!-- Specifies the level of the debugscript log file. Available values: 0, 1, 2, 3. When not set, defaults to 0. -->
| |
| <scriptdebugloglevel>0</scriptdebugloglevel></syntaxhighlight>
| |
| | |
| You want to make sure you have a log name specified. Also you want to specify what level of errors will be logged. If it is 0 nothing will be logged. The levels were explained at the top of this article. If the logging level was changed to 3, then in this case all '''serverside''' script errors log to (MTA root folder)>server>mods>deathmatch>logs>scripts.log
| |
| | |
| ====Client====
| |
| Navigate to: ''(MTA root folder)>server>clientscript.log''
| |
| | |
| This file logs all '''clientside''' script errors. This is set to log by default, no setup required.
| |
| | |
| ==Debug strategies==
| |
| There are several strategies that support finding errors, apart from going through the code. Most of them include outputting debug messages, with have different information depending on the situtation.
| |
| | |
| ===Useful functions===
| |
| There are some functions that may come in handy for debugging.
| |
| * [[outputDebugString]] or [[outputChatBox]] for outputting any information (use outputDebugString for technical output)
| |
| * [http://www.lua.org/manual/5.1/manual.html#pdf-tostring tostring()] on a variable to turn the value into a string. Useful if the value is not a number or string.
| |
| * [[getElementType]] to check the type of the MTA element.
| |
| * [[isElement]] to check if the MTA element exists.
| |
| | |
| ===Add debugmessages to check ''if'', ''when'' or ''how often'' a section of code is executed===
| |
| A typical example would be verify whether an ''if''-section is executed or not. To do that, just add any message you will recognize later within the ''if''-section.
| |
| <syntaxhighlight lang="lua">
| |
| if (variable1 == variable2) then
| |
| outputDebugString("variable1 is the same as variable2!")
| |
| -- do anything
| |
| end
| |
| </syntaxhighlight>
| |
| | |
| Another application would be to check when variable values are modified. First search for all occurences of the variable being edited and add a message just beside it.
| |
| | |
| ===Add debugmessages to check the ''value'' of a variable===
| |
| Let's say you want to create a marker, but it doesn't appear at the position you expect it to be. The first thing you might want to do is check if the [[createMarker]] function is executed. But while doing this, you can also check the values being used in the [[createMarker]] function in one run.
| |
| <syntaxhighlight lang="lua">
| |
| outputChatBox("posX is: "..x.." posY is: "..y.." posZ is: "..z)
| |
| createMarker(x,y,z)
| |
| </syntaxhighlight>
| |
| This would output all three variables that are used as coordinates for the marker. Assuming you read those from a map file, you can now compare the debug output to the desired values. The [http://www.lua.org/manual/5.1/manual.html#pdf-tostring tostring()] will ensure that the values of the variables can be concatenated (put together) as a string, even if it's a boolean value.
| |
| | |
| ==Example==
| |
| Imagine you created a [[Colshape|collision shape]] somewhere and you want an action to perform after the player stays for ten seconds inside it, you would do this:
| |
| <syntaxhighlight lang="lua">
| |
| function colShapeHit(player)
| |
| -- set a timer to output a message (could as well execute another function)
| |
| -- store the timer id in a table, using the player as index
| |
| colshapeTimer[player] = setTimer(outputChatBox,10000,1,"The player stayed 10 seconds in the colshape!")
| |
| end
| |
| addEventHandler("onColShapeHit", root, colShapeHit)
| |
| | |
| function colShapeLeave(player)
| |
| -- kill the timer when the player leaves the colshape
| |
| killTimer(colshapeTimer[player])
| |
| end
| |
| addEventHandler("onColShapeLeave", root, colShapeLeave)
| |
| </syntaxhighlight>
| |
| When a player enters the colshape, debugscript outputs the following message:
| |
| :{{Debug error|..[path]: attempt to index global 'colshapeTimer' (a nil value)}}
| |
| This means you tried to index a table that does not exist (because the table is a nil value, it doesn't exist). In the example above, this is done when storing the timer id in the table. We need to add a check if the table exists and if it does not exist we should create it.
| |
| | |
| <syntaxhighlight lang="lua">
| |
| function colShapeHit(player)
| |
| if (colshapeTimer == nil) then
| |
| colshapeTimer = {}
| |
| end
| |
| -- set a timer to output a message (could as well execute another function)
| |
| -- store the timer id in a table, using the player as index
| |
| colshapeTimer[player] = setTimer(outputChatBox,10000,1,"The player stayed 10 seconds in the colshape!")
| |
| end
| |
| addEventHandler("onColShapeHit", root, colShapeHit)
| |
| | |
| function colShapeLeave(player)
| |
| -- kill the timer when the player leaves the colshape
| |
| killTimer(colshapeTimer[player])
| |
| end
| |
| addEventHandler("onColShapeLeave",root,colShapeLeave)
| |
| </syntaxhighlight>
| |
| | |
| Now we will still receive a warning when a player enters the colshape, waits for the message and leaves it again:
| |
| | |
| :{{Debug warning|[..]: Bad argument @ 'killTimer' Line: ..}}
| |
| | |
| Except for that (we will talk about that later) everything seems to work fine. A player enters the colshape, the timer is started, if he stays the message occurs, if he leaves the timer is killed.
| |
| | |
| ===A more inconspicuous error===
| |
| But for some reason the message gets outputted twice when you stay in the colcircle while in a vehicle. Since it would appear some code is executed twice, we add debug messages to check this.
| |
| | |
| <syntaxhighlight lang="lua">
| |
| function colShapeHit(player)
| |
| if (colshapeTimer == nil) then
| |
| colshapeTimer = {}
| |
| end
| |
| -- add a debug message
| |
| outputDebugString("colShapeHit")
| |
| -- set a timer to output a message (could as well execute another function)
| |
| -- store the timer id in a table, using the player as index
| |
| colshapeTimer[player] = setTimer(outputChatBox,10000,1,"The player stayed 10 seconds in the colshape!")
| |
| end
| |
| addEventHandler("onColShapeHit",getRootElement(),colShapeHit)
| |
| | |
| function colShapeLeave(player)
| |
| -- add a debug message
| |
| outputDebugString("colShapeLeave")
| |
| -- kill the timer when the player leaves the colshape
| |
| killTimer(colshapeTimer[player])
| |
| end
| |
| addEventHandler("onColShapeLeave",getRootElement(),colShapeLeave)
| |
| </syntaxhighlight>
| |
| | |
| Now we notice that both handler functions get executed twice when we are in a vehicle, but only once when we are on-foot. It would appear the vehicle triggers the colshape as well. To confirm this theory, we ensure that the ''player'' variable actually holds a reference to a player element.
| |
| | |
| <syntaxhighlight lang="lua">
| |
| function colShapeHit(player)
| |
| if (colshapeTimer == nil) then
| |
| colshapeTimer = {}
| |
| end
| |
| -- add a debug message, with the element type
| |
| outputDebugString("colShapeHit "..getElementType(player))
| |
| -- set a timer to output a message (could as well execute another function)
| |
| -- store the timer id in a table, using the player as index
| |
| colshapeTimer[player] = setTimer(outputChatBox,10000,1,"The player stayed 10 seconds in the colshape!")
| |
| end
| |
| addEventHandler("onColShapeHit",getRootElement(),colShapeHit)
| |
| | |
| function colShapeLeave(player)
| |
| -- add a debug message, with the element type
| |
| outputDebugString("colShapeLeave "..getElementType(player))
| |
| -- kill the timer when the player leaves the colshape
| |
| killTimer(colshapeTimer[player])
| |
| end
| |
| addEventHandler("onColShapeLeave",getRootElement(),colShapeLeave)
| |
| </syntaxhighlight>
| |
| | |
| The debug messages tell us that one of the ''player'' variables is a player and that the other one is a vehicle element. Since we only want to react when a player enters the colshape, we add an ''if'' that will end the execution of the function if it's '''not''' an player element.
| |
| | |
| <syntaxhighlight lang="lua">
| |
| function colShapeHit(player)
| |
| if (colshapeTimer == nil) then
| |
| colshapeTimer = {}
| |
| end
| |
| -- add a check for the element type
| |
| if (getElementType(player) ~= "player") then return end
| |
| -- add a debug message, with the element type
| |
| outputDebugString("colShapeHit "..getElementType(player))
| |
| -- set a timer to output a message (could as well execute another function)
| |
| -- store the timer id in a table, using the player as index
| |
| colshapeTimer[player] = setTimer(outputChatBox,10000,1,"The player stayed 10 seconds in the colshape!")
| |
| end
| |
| addEventHandler("onColShapeHit",getRootElement(),colShapeHit)
| |
| | |
| function colShapeLeave(player)
| |
| -- add a check for the element type
| |
| if (getElementType(player) ~= "player") then return end
| |
| -- add a debug message, with the element type
| |
| outputDebugString("colShapeLeave "..getElementType(player))
| |
| -- kill the timer when the player leaves the colshape
| |
| killTimer(colshapeTimer[player])
| |
| end
| |
| addEventHandler("onColShapeLeave",getRootElement(),colShapeLeave)
| |
| </syntaxhighlight>
| |
| | |
| Now the script should work as desired, but it will still output the warning mentioned above. This happens because the timer we try to kill when a player leaves the colshape will not exist anymore when it has reached the 10 seconds (and therefore executed after the 10th second has completed). There are different ways to get rid of that warning (since you know that the timer might not exist anymore and you only want to kill it if it exists). One way would be to check if the timer referenced in the table really exists. To do this, we need to use [[isTimer]], which we will use when we kill the timer:
| |
| <syntaxhighlight lang="lua">
| |
| if (isTimer(colshapeTimer[player])) then
| |
| killTimer(colshapeTimer[player])
| |
| end
| |
| </syntaxhighlight>
| |
| | |
| So the complete working code would be:
| |
| <syntaxhighlight lang="lua">
| |
| function colShapeHit(player)
| |
| if (colshapeTimer == nil) then
| |
| colshapeTimer = {}
| |
| end
| |
| -- add a check for the element type
| |
| if (getElementType(player) ~= "player") then return end
| |
| -- add a debug message, with the element type
| |
| outputDebugString("colShapeHit "..getElementType(player))
| |
| -- set a timer to output a message (could as well execute another function)
| |
| -- store the timer id in a table, using the player as index
| |
| colshapeTimer[player] = setTimer(outputChatBox,10000,1,"The player stayed 10 seconds in the colshape!")
| |
| end
| |
| addEventHandler("onColShapeHit",getRootElement(),colShapeHit)
| |
| | |
| function colShapeLeave(player)
| |
| -- add a check for the element type
| |
| if (getElementType(player) ~= "player") then return end
| |
| -- add a debug message, with the element type
| |
| outputDebugString("colShapeLeave "..getElementType(player))
| |
| -- kill the timer when the player leaves the colshape
| |
| if (isTimer(colshapeTimer[player])) then
| |
| killTimer(colshapeTimer[player])
| |
| end
| |
| end
| |
| addEventHandler("onColShapeLeave",getRootElement(),colShapeLeave)
| |
| </syntaxhighlight>
| |
| | |
| | |
| ==Debugging Performance Issues==
| |
| | |
| If your server is using up more resources than it should or you just want to make sure your scripts are efficient, you can find the source of the issue by using a great tool that comes with the default resource package called [[Resource:Performancebrowser|performancebrowser]]. You can start it with ''''start performancebrowser''''. If it doesn't exist then you can get the latest resources from the [https://github.com/multitheftauto/mtasa-resources GitHub repository]. This tool provides an incredible amount of information for performance debugging. Memory leaks, element leaks and CPU intensive scripts are all easily findable via performancebrowser. If you use the ''''d'''' option in Lua timing you can see which functions are using up the CPU.
| |
| | |
| To access performancebrowser you will need to go to your web browser and enter the address: http://serverIPHere:serverHTTPPortHere/performancebrowser/ Note that the / at the end is required. So for example: http://127.0.0.1:22005/performancebrowser/ You will then need to login with an in-game admin account or any account that has access to ''''resource.performancebrowser.http'''' and ''''resource.ajax.http''''. Most of the information you will need are in the categories Lua timing and Lua memory, look for values that are much higher than other values.
| |
| | |
| ===Examples of scripts that could cause performance problems===
| |
| | |
| Adding data to a table but never removing it. This would take months/years before it causes a problem though.
| |
| <syntaxhighlight lang="lua">
| |
| local someData = {}
| |
| | |
| function storeData()
| |
| someData[source] = true
| |
| -- There is no handling for when a player quits, this is considered a memory leak
| |
| -- Using the Lua timing tab you can detect the RAM usage of each resource.
| |
| end
| |
| addEventHandler("onPlayerJoin", root, storeData)
| |
| </syntaxhighlight>
| |
| | |
| Element leaking is possible if you use temporary colshapes for whatever reason and may not destroy them. This would cause bandwidth, CPU and memory performance issues over time.
| |
| <syntaxhighlight lang="lua">
| |
| function useTemporaryCol()
| |
| local col = createColCircle(some code here)
| |
| if (normally this should happen) then
| |
| destroyElement(col)
| |
| end
| |
| -- But sometimes it didn't so the script ended but the collision area remained and over time
| |
| -- you may end up with hundreds to thousands of pointless collision areas.
| |
| -- The Lua timing tab allows you to see the amount of elements each script has created.
| |
| end
| |
| </syntaxhighlight>
| |
| | |
| High CPU usage resulting in the server FPS dropping so much that the server is unplayable. In under 24 hours this can create havoc on a very busy server. The amount of "refs" in the Lua timing detect this type of build up, surprisingly the Lua timing tab didn't help in this case but Lua memory did.
| |
| <syntaxhighlight lang="lua">
| |
| addEventHandler("onPlayerJoin", root, function()
| |
| -- Code for joiner
| |
| addEventHandler("onPlayerQuit", root, function()
| |
| -- Code for when they have quit
| |
| -- See the problem? It's bound to root which the event handler is being added again and again and again
| |
| end)
| |
| end)
| |
| </syntaxhighlight>
| |
| | |
| A function uses up a lot of your CPU because whatever it does takes a long time. This is just some function that takes a long time to complete. Without performancebrowser you'd have no idea its the cause but with performancebrowser you can see that a resource is using lots of CPU in the Lua timing tab. If you then enter: ''''d'''' into the options edit box it will even tell you what file name and first line of the function that is using up so much CPU.
| |
| <syntaxhighlight lang="lua">
| |
| function someDodgyCode()
| |
| for i=1, 100000 do
| |
| -- some code
| |
| end
| |
| end
| |
| </syntaxhighlight>
| |
| | |
| [[it:Guida al Debug]]
| |
| [[Category:Scripting Concepts]]
| |
| [[ru:Debugging]]
| |
| [[Category:Tutorials]]
| |