Talk:IsValueInTable: Difference between revisions
Jump to navigation
Jump to search
(Created page with "Why would you need to pass the column ID when checking if a table contains a value? When you use a function like "isValueInTable" it comes predetermined you don't known its po...") |
No edit summary |
||
| Line 1: | Line 1: | ||
Why would you need to pass the column ID when checking if a table contains a value? When you use a function like "isValueInTable" it comes predetermined you don't known its position. This useful function seems to be tied to a specific need of the author which isn't generic enough to receive the name "isValueInTable". If you take a closer look to the algorithm what it does is look for a value inside a table that's inside an array of tables. | Why would you need to pass the column ID when checking if a table contains a value? When you use a function like "isValueInTable" it comes predetermined you don't known its position. This useful function seems to be tied to a specific need of the author which isn't generic enough to receive the name "isValueInTable". If you take a closer look to the algorithm what it does is look for a value inside a table that's inside an array of tables. | ||
For this matter we should remove this useful function or rewrite it to be exactly "isValueInTable" and suggest renaming it to "table.includes". | For this matter we should remove this useful function or rewrite it to be exactly "isValueInTable" and I suggest renaming it to "table.includes". | ||
Latest revision as of 16:15, 12 August 2021
Why would you need to pass the column ID when checking if a table contains a value? When you use a function like "isValueInTable" it comes predetermined you don't known its position. This useful function seems to be tied to a specific need of the author which isn't generic enough to receive the name "isValueInTable". If you take a closer look to the algorithm what it does is look for a value inside a table that's inside an array of tables.
For this matter we should remove this useful function or rewrite it to be exactly "isValueInTable" and I suggest renaming it to "table.includes".